fix: use Response instead of StreamingResponse for trace download end…#81
Merged
fix: use Response instead of StreamingResponse for trace download end…#81
Conversation
…point slowapi middleware buffers http.response.start to inject rate-limit headers, which conflicts with StreamingResponse — causing RuntimeError when the body arrives before the start message is flushed. Replace the single-yield generator with a plain Response that builds the zip in memory first.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 1 high |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
TIP This summary will be updated as you push new changes. Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slowapi middleware buffers http.response.start to inject rate-limit headers, which conflicts with StreamingResponse — causing RuntimeError when the body arrives before the start message is flushed. Replace the single-yield generator with a plain Response that builds the zip in memory first.