Open
Conversation
Contributor
FangfeiLi05
approved these changes
Sep 7, 2021
Contributor
|
@FangfeiLi05 I just want to point out that this is not yet merged... do you want me to help merge the cherry-picked edits for the setup.py ?? |
Contributor
|
@FangfeiLi05 I would recommend rejecting this. I am making another pull request that fetches from Carsten's repo to cherry-pick the setup.py change you told me you wanted, then you can pull that request. I believe/hope this will still reflect Carsten's writing of the setup.py file..... |
Author
|
sounds reasonable to me.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a basic
setup.pyfor easy installation viapip install .from the repo's root. This also allows installation ofpyfitseqas a dependency in other python packages via arequirements.py(pip) orenvironments.yml(conda).pyfitseq.pyandevo_simulator.pyare moved to the src directoryPyFitSeq/.The second change affects the signature of
pyfitseq.main(). With this change, one can runpyfitseqdirectly from within a python script or notebook without having to exit to the terminal. Output data from pyfitseq are returned as apandas.DataFrameto the caller and written to csv file if requested.In a python script or notebook, one would: