Fix JSON errors in data-types.md#56
Open
chriswait wants to merge 2 commits intoFareHarbor:masterfrom
Open
Conversation
fix semicolons in json sample
chriswait
changed the title
Contributor
|
Thank you Chris! We didn't anticipate fixes from folks outside FH, so it took us a while to notice your thoughtful PR. We're incorporating your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data-types.md contains various samples of JSON payloads.
In several of these, a semicolon has been used in place of a colon, resulting in errors when debugging webhooks using these examples:
In others, there are 2x closing quotes.