Conversation
bermannoah
left a comment
bermannoah
left a comment
There was a problem hiding this comment.
Since this is still public, I think it's worth automating the build process as much as we can. Not necessarily entirely in this PR, but if we can at least auto-increment the version number that's a good start. Would also help to document why we want to use musl.
| # so we need to compile it inside a container | ||
| # and manually push the binary to github | ||
|
|
||
| VERSION=${VERSION:=0.18} |
There was a problem hiding this comment.
We probably want to automate this step and the upload phase. For now, can we pull and increment the version automatically, rather than hard-coding? Can use this to list recent versions: https://docs.github.com/en/rest/reference/repos#list-releases (We might also want to make musl releases distinct from the github actions generated releases, unless we remove that feature altogether).
| @@ -0,0 +1,20 @@ | |||
| FROM alpine:latest | |||
|
|
|||
| RUN apk add --no-cache git make musl-dev go | |||
There was a problem hiding this comment.
Can we document why we're building with musl? Either here or in the readme.
2 participants
Because there's no way for github actions to build golang binaries with musl library, we need to spin up a container, compile it there, and manually upload to Releases.