[OoT] Add missing versions to oot_versions_items and add overlay support for quick import
#482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yanis002
added
oot
Yanis002
changed the title
oot_versions_items and add overlay support for quick importoot_versions_items and add overlay support for quick import
Lilaa3
requested changes
Apr 17, 2025
Collaborator
Lilaa3
left a comment
Lilaa3
left a comment
There was a problem hiding this comment.
Some questions before I approve
Comment on lines
+209
to
+210
| if len(parsedCutscenes) == 0: | ||
| raise PluginError("ERROR: No cutscene was found.") |
Collaborator
There was a problem hiding this comment.
Is this intended for scene imports as well? Deku tree inside won´t import with Cutscene importing on now.
Collaborator
Author
There was a problem hiding this comment.
I'll investigate that, it should import properly so there might be something going on
Collaborator
Author
There was a problem hiding this comment.
I tested and it works properly, though it won't work if you already imported that cutscene before, which might be a concern so I changed it to make it print a warning instead of skipping the import entirely
Dragorn421
approved these changes
May 19, 2025
Dragorn421
added
the
merge soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quick import file was a bit messy so I decided to improve it a bit in the process, also I wanted to add the missing versions to the enum
Now you can use the quick import feature to import data from overlays, I tested it with
D_808BCE20I decided to add a new preview setting to ignore the cutscene misc command that stops the cutscene, in some cases it can be useful