-
Notifications
You must be signed in to change notification settings - Fork 100
[OoT] Improve how lighting is handled #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reonu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine as well
|
will be merged in 24 hours from now unless something else comes up |
sauraen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe vanilla scenes with more than four lights always have multiple sets of time-of-day lights. In other words, if you're using time-of-day mode, fast64 should support multiples of 4 lights, and allow you to pick which set you want to use for preview. Keep in mind that the time-of-day system doesn't have to support arbitrary numbers of lights--you can always switch to custom for that.
But this change is better than the code was, so still approving.
|
oh I see, I missed that, I'll make the change soon |
|
alright should be ready now, I changed the implementation of what this PR does and I also fixed the importer (+ added a better organisation of the objects for convenience) |
Reonu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work fine
This adds an extra list of light settings to the time of day mode, in some cases (or by personal preference) you may want to have more than 4 settings in that mode and fast64 is currently forcing that, so that basically address the
TODOthere is about itAlso this PR is fixing a bug where having
LIGHT_MODE_TIMEas the custom setting wouldn't export everything