Skip to content

Conversation

@Yanis002
Copy link
Collaborator

This adds an extra list of light settings to the time of day mode, in some cases (or by personal preference) you may want to have more than 4 settings in that mode and fast64 is currently forcing that, so that basically address the TODO there is about it

Also this PR is fixing a bug where having LIGHT_MODE_TIME as the custom setting wouldn't export everything

@Yanis002 Yanis002 added enhancement New feature or request oot Has to do with the Ocarina of Time 64 side labels Oct 30, 2025
Copy link
Contributor

@Reonu Reonu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine as well

@Yanis002 Yanis002 added the merge soon Will be merged in a few days at most if nothing else comes up label Nov 9, 2025
@Yanis002
Copy link
Collaborator Author

Yanis002 commented Nov 9, 2025

will be merged in 24 hours from now unless something else comes up

Copy link
Collaborator

@sauraen sauraen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe vanilla scenes with more than four lights always have multiple sets of time-of-day lights. In other words, if you're using time-of-day mode, fast64 should support multiples of 4 lights, and allow you to pick which set you want to use for preview. Keep in mind that the time-of-day system doesn't have to support arbitrary numbers of lights--you can always switch to custom for that.

But this change is better than the code was, so still approving.

@Yanis002
Copy link
Collaborator Author

Yanis002 commented Nov 9, 2025

oh I see, I missed that, I'll make the change soon

@Yanis002
Copy link
Collaborator Author

alright should be ready now, I changed the implementation of what this PR does and I also fixed the importer (+ added a better organisation of the objects for convenience)

Copy link
Contributor

@Reonu Reonu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine

@Yanis002 Yanis002 merged commit 85bdf3c into Fast-64:main Nov 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request merge soon Will be merged in a few days at most if nothing else comes up oot Has to do with the Ocarina of Time 64 side

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants