-
Notifications
You must be signed in to change notification settings - Fork 100
[OoT] Add new Animated Materials types #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
should be ready now, I don't think I want to add anything else |
Contributor
Reonu
approved these changes
Nov 25, 2025
Contributor
Reonu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature needs to be documented in a wiki or similar when you have time because it's pretty complex and easy to mess up. But the PR itself looks good to me, it works.
Collaborator
Author
|
thanks, merging soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
merge soon
Will be merged in a few days at most if nothing else comes up
oot
Has to do with the Ocarina of Time 64 side
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Lately I've been working on adding new animated materal types for HackerOoT, this is what this PR implements
I had to do stupid things to get a decent user experience for the surface swap type but hey it works apparently (didn't do any testing as of right now but will do soon!)
related HackerOoT PR: HackerN64/HackerOoT#192