Feature: byte_size and char_length#135
Merged
stackmystack merged 5 commits intomasterfrom Dec 18, 2025
Merged
Conversation
b5a7dc3 to
41a4247
Compare
888c058 to
cf13521
Compare
Useful for passing config from containers. See previous commit.
fd46b3a to
45d8ed6
Compare
4befe9c to
be981cd
Compare
akimd
approved these changes
Dec 15, 2025
`.length` calls were inconsistent across vendors, and it also contained a bug that didn't return what you expect. For that reason, we deprecate length, and we ask people to use the more reliable `.byte_size` and `.char_length` instead.
be981cd to
683ddb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem with the current implementation of
lengthis that it's unreliable across vendors.The newly introduced functions will give correct semantics across vendors.
Some details may vary, still, unfortunately: mssql stores by default in UTF-16 and, the author needs to pay close attention to their maths.
Closes #134.