Merged
Conversation
GusOhnesorge
requested review from
ammesonb and
liammaier
and removed request for
ammesonb
ammesonb
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses DEV-5858
Use default tics for deleted products
Testing for product tics service
fixes api service tests
Also creates a set of Magento mocks that we can bootstrap over the paths that typically go to the full magento framework. Since this is an extension we aren't able to create a whole magento framework environment, but this way we have classes that we can then mock the functionality of. The hope is that the underlying functionality of Magento wouldn't ever change that much, but our tests will fail if we update the main code so.