Fix QIT workflow SASS build failure#367
Open
devin-ai-integration[bot] wants to merge 5 commits intodevelopfrom
Open
Fix QIT workflow SASS build failure#367devin-ai-integration[bot] wants to merge 5 commits intodevelopfrom
devin-ai-integration[bot] wants to merge 5 commits intodevelopfrom
Conversation
- Remove --no-dev flag to include WooCommerce dev dependency - WooCommerce dependency contains required SASS partials (_colors, _variables, _breakpoints, _mixins) - Matches working deploy workflow configuration - Keeps --optimize-autoloader flag for performance Co-Authored-By: lmaier@taxcloud.com <lmaier@taxcloud.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…lication_password - Update QIT workflow to use --qit_token parameter (current method) - Update documentation to reflect QIT Token requirements - Application passwords are deprecated and no longer work - Fixes authentication failure in QIT workflow Co-Authored-By: lmaier@taxcloud.com <lmaier@taxcloud.com>
- Replace managed test commands (qit run:activation, qit run:security) with custom E2E test - Use qit run:e2e with --zip parameter for non-Marketplace plugins - Add --wait flag to ensure tests complete before workflow continues - Update documentation to reflect custom E2E test approach - Fixes 'No tests found for the given plugins' error Co-Authored-By: lmaier@taxcloud.com <lmaier@taxcloud.com>
- Replace --zip=simple-sales-tax.zip with --source=simple-sales-tax.zip - Based on QIT CLI source code analysis in RunE2ECommand.php - Fixes 'The --zip option does not exist' error - Completes QIT workflow implementation for custom E2E tests Co-Authored-By: lmaier@taxcloud.com <lmaier@taxcloud.com>
- QIT CLI RunE2ECommand does not support --wait option - Based on source code analysis of RunE2ECommand.php - Fixes 'The --wait option does not exist' error - Command now uses: qit run:e2e simple-sales-tax --source=simple-sales-tax.zip Co-Authored-By: lmaier@taxcloud.com <lmaier@taxcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix QIT workflow SASS build failure, authentication, and test discovery issues
Summary
This PR fixes three critical issues preventing the QIT (Quality Insights Toolkit) workflow from running successfully:
SASS Build Failure: The QIT workflow was failing during the "Build plugin" step because
composer install --no-devexcluded the WooCommerce dev dependency containing required SASS partial files (_colors,_variables,_breakpoints,_mixins) that webpack automatically imports.Authentication Failure: The QIT workflow was using the deprecated
--application_passwordparameter instead of the current--qit_tokenparameter, causing authentication to fail with empty credentials.Test Discovery Failure: The workflow was using managed test commands (
qit run:activation,qit run:security) which require WooCommerce Marketplace registration. Since the plugin is not in the Marketplace, QIT reported "No tests found for the given plugins."Key Changes:
--no-devflag from composer install in QIT workflow to include WooCommerce SASS files--application_passwordto--qit_tokenqit run:e2ewith--zipparameterQIT_APP_PASStoQIT_TOKENReview & Testing Checklist for Human
--qit_tokenparameter and updatedQIT_TOKEN+QIT_USERsecretsqit run:e2e simple-sales-tax --zip=simple-sales-tax.zip --waitactually runs tests and doesn't return "No tests found" error_colors,_variables, etc.Recommended Test Plan:
Diagram
%%{ init : { "theme" : "default" }}%% graph TD qit_yml[".github/workflows/qit.yml"]:::major-edit qit_setup["QIT_SETUP.md"]:::minor-edit composer_json["composer.json"]:::context webpack_config["webpack.config.js"]:::context qit_yml --> |"composer install<br/>(removed --no-dev)"| composer_json composer_json --> |"includes WooCommerce<br/>dev dependency"| webpack_config webpack_config --> |"auto-imports<br/>SASS partials"| sass_files["WooCommerce SASS files<br/>(_colors, _variables, etc.)"]:::context qit_yml --> |"qit partner:add<br/>--qit_token"| auth["QIT Authentication"]:::context auth --> |"uses QIT_TOKEN<br/>secret"| github_secrets["GitHub Secrets<br/>(QIT_USER, QIT_TOKEN)"]:::context qit_yml --> |"qit run:e2e<br/>--zip parameter"| custom_tests["Custom E2E Tests"]:::context custom_tests --> |"tests uploaded<br/>plugin zip"| plugin_zip["simple-sales-tax.zip"]:::context subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
Root cause analysis:
--application_passwordin favor of--qit_token(discovered by examining QIT CLI source code)Testing limitation: Unable to test QIT workflow end-to-end locally due to authentication requirements and external service dependencies. The fixes are based on thorough documentation research and QIT CLI source code analysis, but require manual verification.
Documentation inconsistency: Official QIT documentation showed mixed examples (some still using deprecated parameters), so implementation was based on CLI source code analysis and multiple documentation sources.
Session info: Requested by lmaier@taxcloud.com - Link to Devin run
Risk Assessment: Medium-High - Authentication and test approach changes for external services that couldn't be fully tested end-to-end. Manual QIT workflow testing is essential to verify the fixes work correctly.