Edit filters to be more readable and easier to define#18
Merged
JooNiv merged 7 commits intorewrite/mainfrom Jun 12, 2025
Merged
Edit filters to be more readable and easier to define#18JooNiv merged 7 commits intorewrite/mainfrom
JooNiv merged 7 commits intorewrite/mainfrom
Conversation
Modupef
reviewed
Jun 9, 2025
| value: true | ||
| Theme: "course/workshop" | ||
| Pricing: Free of charge # Free of charge, or empty if paid | ||
| Availability: Open to anyone # Open to anyone, Registration needed |
There was a problem hiding this comment.
I think Mikael said to use just "Open" instead of "Open to anyone". Maybe confirm this?
Member
Author
There was a problem hiding this comment.
We can ask on Thursday when we have a team meeting. I'll write an initial version of the resource (get access page) descriptions to also run by him 👍
Modupef
reviewed
Jun 9, 2025
| - name: "News" | ||
| value: false | ||
| Theme: "Technical" | ||
| Skill level: Beginner # Beginner, Advanced |
There was a problem hiding this comment.
What happens when
- Someone misspells the skill level e.g "Beginer" instead of "Beginer" or if a person uses lowercase "beginner"?
- What happens if they use 2 values "Beginner, Advanced" ?
Member
Author
There was a problem hiding this comment.
- Case does not matter. Otherwise misspelled category will just result to the event/blog not showing up in any category
- I think rn that would count as misspelled but maybe it would be smarter to allow for multiple values and have the blog / event show up under both. Not a big change so I'll try to get to it this week
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit filters to match what was discussed in the demo meeting:
Events:
Blogs: