hacky fix for missing segment near the end of dst file#2
Open
Hark0nnen wants to merge 1 commit intoFichteFoll:masterfrom
Open
hacky fix for missing segment near the end of dst file#2Hark0nnen wants to merge 1 commit intoFichteFoll:masterfrom
Hark0nnen wants to merge 1 commit intoFichteFoll:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sushi doesnt not handle missing segments in destination file vert well (it ouputs corresponding subtitles with a pretty random timings), but there is a particularly bad case when missing segment is near the end of dst fiel and is longer than matching segment at the very end - it causes sushi to crash with attempt to perform operations on NoneType.
This is a very hacky fix for this particular case
It would be better to fix handling of missing segments properly, but i do not understand sushi code to attempt that.