You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it's that TransientCurrentPlugin::UpdateDatabase is modifying the database (EDIT: and other vectors) in one thread while TransientCurrentPlugin::CalculateOceanCurrent is reading it another.
Then I locked TransientCurrentPlugin::UpdateDatabase as well. It's been running for 6 hours (sim time)/11 minutes (real time) now without an issue.
And about the branch organization,
Most of what we nees would be in #180. It would not include intlatlon, gpaviewer and stuff. So I am trying to keep the bathymetry_plugin_whoi branch at my fork.
the branch will not be in upatream dave and will not be merges into master. Dave team has decided not to include bathymetry files in the repo but make it downloadable reading the tutorial. The download file includes both bathymery examples(not buzzbay) and initlatlon/gps viewer.
The branch at my fork will include Buzzbay and some puerto rico and minor adjustings for epic-daug if needed.
In Field-Robotics-Lab/glider_hybrid_whoi#66, the pre-release I was hoping to get it tested and merged after usjng the simulator as it ia for the puertorico, the target repo is changed from Field-Robotics-Lab/dave to woensugchoi/dave
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field-Robotics-Lab/glider_hybrid_whoi#64
This PR tries to lock and unlock the function.