fix: remove npm ci from publish-abis workflow #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: remove npm ci from publish-abis workflow
|
It passed with the fix, but is now failing because GH Releases requires a tag: https://github.com/FilOzone/pdp/actions/runs/17792580649 I have also tested it manually: I upload these assets manually to the release: https://github.com/FilOzone/pdp/releases/tag/v2.1.0. I see that there is a lot of Abi-files, is dumping them all in there fine. Or should it have created a directory or something with these files to make it neater? |
rjan90
added a commit
to FilOzone/filecoin-pay
that referenced
this pull request
Sep 19, 2025
Similar to: FilOzone/pdp#199. The publish-abis on releases workflow are failing (https://github.com/FilOzone/filecoin-pay/actions/runs/17854873063) because it tried to run `npm ci` on a Foundry project that doesn't have package.json at the root. We only need `forge install` for Solidity dependencies.
ZenGround0
approved these changes
Sep 25, 2025
github-project-automation
bot
moved this from 🔎 Awaiting review
to ✔️ Approved by reviewer
in FS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
publish-abis.ymlworkflow was failing after the publishing of v2.1.0 here: https://github.com/FilOzone/pdp/actions/runs/17792160390 because it tried to runnpm ci, but PDP doesn't have apackage.jsonfile at the root level iiuc.I removed the unnecessary
npm cistep. The workflow now only runsforge installwhich is all that's needed for Foundry dependency management.