Trashcan folder "same volume" check is too restrictive #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code only allowed sibling folders of the root dir (which doesn't actually guarantee anything about them being on the same volume or not). This is too restrictive (e.g. for hiding the folder inside Android's external files dir), so allow children of the root folder, too.
I know a better method to check for the "same volume" condition, but it's Android-specific. So until somebody can come up with a platform-independendent way of implementing this check properly, allow overriding this method by implementers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I'm understanding it right, the current "Make sure the trashcan folder is on the same volume as the shared folder, so we can rename deleted files" check basically only allows siblings of the shared folder when setting a custom trashcan path.
In my opinion, this is
a) unnecessarily restrictive and
b) doesn't even guarantee that the two folders actually are residing on the same volume, because what with mountpoints, filesytem junctions, symbolic links and what not any two folders in an arbitrary relationship to each other could reside on completely different volumes.
Unfortunately the one proper solution I've quickly stumbled upon seems to be Android-specific (Android has added Java APIs for calling fstat), so for now I'd just suggest perhaps relaxing the check a bit (allowing child folders by default, too), plus adding a hook to allow overriding the check by implementors.