Tmah issue23

[Tanjiha]

Description

Change Metadata

Resolves: # (issue)

This change includes the following change types

• Bug report fix(es)
• Enhancement to assessment(s)
• Enhancement to specification(s)
• Enhancement to tool(s)
• Enhancement to documentation(s)
• Other

Quality Assurance

• I have checked to ensure there are no other open PRs for the same change.
• I have read and am following to the best of my abilities what is in CONTRIBUTING.md
• I have read and am following to the best of my abilities the relevant design, development, and style guidelines

[travissalascox]

hey there @Tanjiha , have a similar question as in PR #62 . It seems like the Max raw scores aren't adding up to the point values here. Was wondering if could elaborate on those a bit more. It seems like 125 adds up to 3*3 + 3*3 + 3*3 + 1*2 = 29 and 126 seems to be coming out to 4*5 + 4*5 + 2*3 + 2*3 = 52

Would have a similar set of suggestions as requested in PR #62 as well. Would remove the talk about normalization and replace it will ranges of raw points in the conditions. Would also move the crawl, walk, run, fly pieces to the Supplemental Guidance section, with references linked under References

One unique request for this one would be to increase the version of 125 to 2.0.0. Only because 125 already seems to have been accepted previously. I like what you did here though. So taking this one would break backwards compatibility for the action, which is perfectly cool. But when that happens, we update that major version in major.minor.patch schema for the version to show this. This is the first time we have had to do this, which is in-and-of-itself pretty cool. I think this is a nice upgrade to the action as it was.

[travissalascox]

great work with this as well @Tanjiha ! Looks like there are three typos that CSpell is catching, after those three are fixed, think this one is ready to go in. The ones CSpell seems to be having issues with is i think it wants licence -> license and licencing -> licensing in action 125, and Integr -> Integer in 126.

[travissalascox]

@Tanjiha thanks for all the updates on this. Don't wanna get you trapped in the pedantic merge conflicts and checks issues since you have put so much into this already. So gonna help out a little with that since my local setup can help me fix those issue pretty quick. Especially since I haven't been able to write up the docs to help with that. Thank you for doing the hard work on this one, coming up with the ideas for the score and getting those down!!

[travissalascox]

I'll pull in your branch locally, and update patch the line-length issues and push them back here. Then will make sure your PR goes in

[vlevy573]

This is awesome, so excited to have this score type and all the notes. Great Job @Tanjiha!

Looks all good now