-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore(nix): improve flake with dynamic version and build optimization #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jerome-benoit
wants to merge
12
commits into
Fission-AI:main
Choose a base branch
from
jerome-benoit:chore/nix-flake-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+162
−63
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b7238ba
chore(nix): improve flake with dynamic version and source filtering
jerome-benoit 386bea6
chore(ci): bump Nix actions to latest versions
jerome-benoit 216c119
chore: add changeset for Nix improvements
jerome-benoit fdb68b7
fix(nix): make update-flake.sh portable to macOS
jerome-benoit 97e5046
fix(nix): properly check build verification exit status
jerome-benoit 98905d3
Merge branch 'main' into chore/nix-flake-improvements
jerome-benoit 75ae291
Merge branch 'main' into chore/nix-flake-improvements
TabishB 890adf1
Merge branch 'main' into chore/nix-flake-improvements
TabishB 96efe0e
Merge branch 'main' into chore/nix-flake-improvements
jerome-benoit ad548eb
Merge branch 'main' into chore/nix-flake-improvements
jerome-benoit c0a0e3d
Merge branch 'main' into chore/nix-flake-improvements
jerome-benoit 1a86f97
Merge branch 'main' into chore/nix-flake-improvements
jerome-benoit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| --- | ||
| "@fission-ai/openspec": patch | ||
| --- | ||
|
|
||
| ### Improvements | ||
|
|
||
| - **Nix flake maintenance** — Version now read dynamically from package.json, reducing manual sync issues | ||
| - **Nix build optimization** — Source filtering excludes node_modules and artifacts, improving build times | ||
| - **update-flake.sh script** — Detects when hash is already correct, skipping unnecessary rebuilds | ||
|
|
||
| ### Other | ||
|
|
||
| - Updated Nix CI actions to latest versions (nix-installer v21, magic-nix-cache v13) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention the output improvement, including colored text for updates and warnings.