Conversation
- extract menu, routes as names export - rename default route to `.landing`.
- Add first set of content with dummy maps and images for CycleNetworkDevelopmentPage - Rename ZesPlusResearchPage to follow the *Page pattern
- use named exports - move maps from components to page-content-folder - add types in a more standard way
- Extract flying legend to component - Standardize import/export of planning legend
The linked extension was not available anymore. This one looks more official.
- Message as children - Make TS - Move to components2
- Move icons to component folders - Cleanup SVGs by removing filter and duplicate circle - Refactor LocatorControl to TS into components2 - Extract LocatorButton from LocatorControl and use that inside the Planung/HBI map, so all Button have the same behavior - Refactor Styling of MapButtons so they all look the same; and less duplicated styles. Also some hover styles and such. - Refactor the layer show/hide feature to be used in the fullscreen map; remove it from the previous test page since the interface is now different - Add a test map on the ZES+ page to test the fullscreen map - This includes a debug panel that allows to show/hide all layers of the current style. HOWEVER, there is something out of sync here (likely due to async data processing internally in mapbox) so the visibility state is only correct after the next click).
This whole folder was only used by the Map-"Product" (HBI/Planungen) (by now), so we should move it in the component folder over there. Also import styles directly from the styles file and rename that so it's easier to understand the imports.
Using `css` here activates the code styling; and does not change the outcome.
- Rename ModalCloseIcon component to ClosePanelButton component - Remove duplicated CloseMapIcon component in favor of reusing ClosePanelButton - Refactor components to use `style` props which overwrite the given styled-components styles automatically. This means, we need to write less code in styled components. - Allow MapsControl to be hidden via props - Add styles for FullscreenMap on mobile - Cleanup FullscreenMap comments and props
This was an experiment that we do not need anymore. The rest of the code was already removed.
Its used by the Article/Map and Article/FullscreenMap.
Lets use true/false props here for position which makes the code a lot easier. Also fixes the visibility of the button on desktop.
- Use named export - Consolidate the types in a /config/types folder - Simplify the types where possible; did not manage to get rid of the per route-types, though; but they are simplified - Add types where missing
Remove React.VFC. This is in preparation for React 18.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1027 +/- ##
===========================================
+ Coverage 36.37% 36.55% +0.17%
===========================================
Files 500 524 +24
Lines 9456 9594 +138
Branches 1946 1969 +23
===========================================
+ Hits 3440 3507 +67
- Misses 5730 5807 +77
+ Partials 286 280 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
It could be useful to use https://github.com/eps1lon/types-react-codemod for automatic migrations to the new explicit type writing for Oh I see, you linked it already :D |
tordans
force-pushed
the
zesplus-update-2022-03
branch
from
d32ea42 to
2bab89c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With React 18, the Types for React.FC changed from including children props to not including them.
Now, React.FC and React.VFC are the same, see https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react/index.d.ts#L508-L526
Changes
TODOs
FYI, es gibt noch mehr deprecated types https://github.com/eps1lon/types-react-codemod#all-deprecated--transforms