use global apiservice in plannings request#606
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #606 +/- ##
===========================================
+ Coverage 25.85% 25.99% +0.13%
===========================================
Files 374 374
Lines 7607 7609 +2
Branches 1899 1908 +9
===========================================
+ Hits 1967 1978 +11
+ Misses 5250 5241 -9
Partials 390 390
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cafca
requested changes
Oct 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What change does this add?
We start to use the centralized api client added in #370 by replacing the direct invocation of
kywith the new servide.Tests make sure the swap did not break anything.
Fixes #542
Fixes #541
How Has This Been Tested?
Run added unit tests
What workload does it derive?
What else is there to notice?
MapState.tsneed some more love. For example we typeMapState.planningas boolean, instead it contains an object containing the raw (?) api responseChecklist: