mapping-utils: Strava GPX Fetcher

[bangarang]

• chore: add /validators folder
• koala: initial commit

Please explain how to summarize this PR for the Changelog:

Tell code reviewer how and what to test:

[flatfile-nullify]

Nullify Code Language: TypeScript 🟡 HIGH Severity CWE-918

Rules lgpl javascript ssrf rule node ssrf

This application allows user-controlled URLs to be passed directly to HTTP client libraries. This can result in Server-Side Request Forgery (SSRF). SSRF refers to an attack where the attacker can abuse functionality on the server to force it to make requests to other internal systems within your infrastructure that are not directly exposed to the internet. This allows the attacker to access internal resources they do not have direct access to.
Some risks of SSRF are:

• Access and manipulation of internal databases, APIs, or administrative panels - Ability to scan internal network architecture and services - Can be used to pivot attacks into the internal network - Circumvent network segregation and firewall rules
  To avoid this, try using hardcoded HTTP request calls or a whitelisting object to check whether the user input is trying to access allowed resources or not.
  Here is an example: var whitelist = [ "https://example.com", "https://example.com/sample" ] app.get('/ssrf/node-ssrf/axios/safe/3', function (req, res) { if(whitelist.includes(req.query.url)){ axios.get(url, {}) .then(function (response) { console.log(response); }) .catch(function (response) { console.log(response); }) } }); For more information on SSRF see OWASP: https://cheatsheetseries.owasp.org/cheatsheets/Server_Side_Request_Forgery_Prevention_Cheat_Sheet.html

⚡ Here's how you might fix this potential vulnerability

The modified code mitigates this vulnerability by validating the activityId before it is used in the axios.get request. It checks if the activityId is a positive integer, which is the expected format for a Strava activity ID. If the activityId is not a positive integer, the function throws an error. This ensures that only valid activity IDs can be used in the request, preventing SSRF attacks.

autoFixesExperimental

Add validation for activityId to prevent SSRF attacks

Suggested change

	const response = await axios.get(
	`https://www.strava.com/api/v3/activities/${activityId}/streams?keys=latlng,altitude,time&key_by_type=true`,
	{
	headers: { Authorization: `Bearer ${accessToken}` },
	}
	)
	if (!Number.isInteger(activityId) || activityId <= 0) {
	throw new Error('Invalid activity ID');
	}
	const response = await axios.get(
	`https://www.strava.com/api/v3/activities/${activityId}/streams?keys=latlng,altitude,time&key_by_type=true`,
	{
	headers: { Authorization: `Bearer ${accessToken}` },
	}
	)

poweredByNullify

Reply with /nullify to interact with me like another developer
_{(you will need to refresh the page for updates)}

[flatfile-nullify]

Nullify Code Vulnerabilities

1 findings found in this pull request

🔴 CRITICAL	🟡 HIGH	🔵 MEDIUM	⚪ LOW
0	1	0	0

You can find a list of all findings here