feat: Add @flatfile/plugin-space-reconfigure plugin #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new plugin for reconfiguring existing Flatfile spaces - Supports updating existing workbooks by name matching - Creates new workbooks for unmatched configurations - Maintains space settings and workbook order - Includes comprehensive e2e and unit tests - Follows same patterns as space-configure plugin Amp-Thread: https://ampcode.com/threads/T-b676df3e-c4b9-4113-81c9-e6dfe80ddd97 Co-authored-by: Amp <amp@ampcode.com>
|
📝 Documentation updates detected! New suggestion: Add comprehensive documentation for @flatfile/plugin-space-reconfigure plugin |
mmccooyyy
approved these changes
Jul 14, 2025
- Add workbook deletion for workbooks not in new configuration - Add sheet matching utility for future sheet-level operations - Update workbook matching to track deletions - Add comprehensive tests for deletion scenarios - Update README to document deletion behavior - Ensure proper cleanup of removed workbooks during reconfiguration Amp-Thread: https://ampcode.com/threads/T-b676df3e-c4b9-4113-81c9-e6dfe80ddd97 Co-authored-by: Amp <amp@ampcode.com>
- Add document matching utility to match by title - Implement document update, delete, and create operations - Add comprehensive document CRUD tests (8 test cases) - Update e2e tests with document CRUD scenarios - Handle case where no documents in config (deletes all existing) - Update README with document CRUD documentation and examples - Ensure setupFactory is authoritative source of truth for documents Amp-Thread: https://ampcode.com/threads/T-b676df3e-c4b9-4113-81c9-e6dfe80ddd97 Co-authored-by: Amp <amp@ampcode.com>
- Add test for maintainWorkbookOrder with workbook deletions - Add comprehensive test for complete space reconfiguration with all resource types - Add test for empty configuration (delete everything scenario) - Ensure workbook order is maintained correctly when workbooks are deleted - Test integration between workbook and document CRUD operations - Cover edge cases like empty workbooks and documents arrays - Verify space settings updates work with resource deletions Amp-Thread: https://ampcode.com/threads/T-b676df3e-c4b9-4113-81c9-e6dfe80ddd97 Co-authored-by: Amp <amp@ampcode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces a new plugin for reconfiguring existing Flatfile spaces by updating existing workbooks and creating new ones as needed.
Key Features
Architecture
The plugin follows the same patterns as plugin-space-configure but focuses on reconfiguration rather than initial setup.
Test Coverage
All tests pass successfully, confirming the plugin is ready for production use.