Skip to content

HEMS example: set --ensure-positive explicitly as it cannot be used as a flag right now#189

Open
nhoening wants to merge 1 commit intomainfrom
fix/forecasting-set-ensure-positive-explicitly
Open

HEMS example: set --ensure-positive explicitly as it cannot be used as a flag right now#189
nhoening wants to merge 1 commit intomainfrom
fix/forecasting-set-ensure-positive-explicitly

Conversation

@nhoening
Copy link
Contributor

@nhoening nhoening commented Mar 9, 2026

PR #180 should move the HEMS example to using forecasts via the API, but in the meantime v0.31 might have introduced a regression in the CLI.

--ensure-positive is intended to be a flag, but we define it via Marshmallow now, and click fails before Marshmallow validates. We have to use --ensure-positive True.

So consider this a quick fix. The CLI should be fixed, but before that is live, we should finish #180 anyway.

This PR might have to stick to the old behavior for FM < v0.31, I am not sure.

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 22845759300

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.815%

Totals Coverage Status
Change from base Build 22532251905: 0.0%
Covered Lines: 582
Relevant Lines: 595

💛 - Coveralls

@nhoening nhoening requested a review from BelhsanHmida March 9, 2026 09:15
@Flix6x Flix6x changed the title HEMS example: set --ensure-postive explicitly as it cannot be used as a flag right now HEMS example: set --ensure-positive explicitly as it cannot be used as a flag right now Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants