HEMS example: set --ensure-positive explicitly as it cannot be used as a flag right now#189
Open
HEMS example: set --ensure-positive explicitly as it cannot be used as a flag right now#189
Conversation
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Pull Request Test Coverage Report for Build 22845759300Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #180 should move the HEMS example to using forecasts via the API, but in the meantime v0.31 might have introduced a regression in the CLI.
--ensure-positiveis intended to be a flag, but we define it via Marshmallow now, and click fails before Marshmallow validates. We have to use--ensure-positive True.So consider this a quick fix. The CLI should be fixed, but before that is live, we should finish #180 anyway.
This PR might have to stick to the old behavior for FM < v0.31, I am not sure.