Drop macOS requirement to 10.15 with availability annotations #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request drops the required macOS version to 10.15 and the required Swift version to 5.9 by introducing availability annotations and some alternative implementations for localisation-related code.
I believe that this is worth the effort because ErrorKit is a widely useful package that could become quite a core dependency within the Swift ecosystem, and requiring macOS 13 limits adoption of not just ErrorKit, but any package looking to depend on ErrorKit.
I've focused on macOS in this PR, but I believe that dropping the other deployment targets wouldn't require much extra effort. The only reason I didn't drop them was because I didn't have a simple way to test those changes at the time and I didn't need to for my own project.
If you'd like me to update this PR to drop the requirements for the other Apple platforms as well let me know and I'll happily do so.