Fix Language Change Issue

[Jack251970]

Follow on with #3365.

Improve Language Initialization

Originally, we use ChangeLanguage to initialize language & change language, which I think is a little bit unclear.

Now I add InitializeLanguage for initializing language and I remove ChangeLanguage in PluginManager because we only need to call it once.

Fix Language Initialization Issue

This function should be called after plugins are initialized because we will call GetTranslatedTitle function to update plugin metadata and many plugins use Context.API to get its translated titles and descriptions, so we would better to call InitAsync before calling this function.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ forbidden-pattern	22
⚠️ ignored-expect-variant	1
⚠️ non-alpha-in-dictionary	19

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request modifies the internationalization workflow. In the PluginManager, two lines handling language directories and changing languages have been removed from the plugin initialization process. In the Internationalization class, methods have been restructured: a new asynchronous InitializeLanguageAsync method has been introduced, the method for adding plugin language directories is now private and parameterless, and the language change functionality has moved from a synchronous to an asynchronous implementation. The App.xaml.cs file has been updated to invoke the asynchronous language initialization instead of the previous synchronous call.

Changes

File	Change Summary
Flow.Launcher.Core/Plugin/PluginManager.cs	Removed two lines in InitializePluginsAsync that added plugin language directories and changed language based on user settings.
Flow.Launcher.Core/Resource/Internationalization.cs	Modified AddPluginLanguageDirectories from a public method accepting parameters to a private parameterless method retrieving plugins internally. Introduced a new public async method InitializeLanguageAsync(), updated ChangeLanguage to ChangeLanguageAsync for asynchronous operations, and adjusted plugin metadata update handling accordingly.
Flow.Launcher/App.xaml.cs	Replaced the synchronous call to ChangeLanguage with an asynchronous call to InitializeLanguageAsync to update plugin titles based on API language settings.

Sequence Diagram(s)

sequenceDiagram
    participant App as App.xaml.cs
    participant Intl as Internationalization
    participant PM as PluginManager

    App->>Intl: InitializeLanguageAsync()
    Intl->>PM: GetPluginsForInterface<IPluginI18n>()
    PM-->>Intl: Return plugin list
    Intl->>Intl: AddPluginLanguageDirectories()
    Intl->>Intl: ChangeLanguageAsync(Language)
    Note right of Intl: Save language setting & update culture
    Intl->>Intl: UpdatePluginMetadataTranslations() (async)
    Intl-->>App: Language initialization complete

Loading

Possibly related PRs

• Localize startup messages about missing Python/NodeJS #2769: Addresses updates in plugin language directory handling and language change within PluginManager.
• Fix Plugin Manager Issue #3365: Involves modifications to the plugin initialization sequence related to language management.

Suggested labels

kind/i18n, enhancement

Suggested reviewers

• jjw24
• taooceros

Poem

I'm a rabbit hopping with delight,
Celebrating code that now runs light.
Async language flows without a hitch,
Plugin metadata gets its niche.
With every hop, the code feels bright! 🐇✨
Happy to see our changes take flight!

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

Flow.Launcher/App.xaml.cs (1)

138-142: Consider handling exceptions from InitializeLanguageAsync

Using an await call for the asynchronous language initialization is appropriate. However, since this initialization occurs during startup, consider wrapping it in a try/catch or logging any exceptions to avoid silent failures if InitializeLanguageAsync encounters issues (e.g., file IO failures, plugin errors).

Flow.Launcher.Core/Resource/Internationalization.cs (1)

70-72: Ensure plugin enumeration is only done when needed

Calling PluginManager.GetPluginsForInterface<IPluginI18n>() each time adds overhead if invoked repeatedly. Since this method is no longer parameter-based, ensure it is only called once or at appropriate intervals to avoid performance issues.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ddec1bd and a3193cf.

📒 Files selected for processing (3)

• Flow.Launcher.Core/Plugin/PluginManager.cs (0 hunks)
• Flow.Launcher.Core/Resource/Internationalization.cs (4 hunks)
• Flow.Launcher/App.xaml.cs (1 hunks)

💤 Files with no reviewable changes (1)

• Flow.Launcher.Core/Plugin/PluginManager.cs

🧰 Additional context used

🧬 Code Definitions (2)

Flow.Launcher/App.xaml.cs (1)

Flow.Launcher.Core/Resource/Internationalization.cs (2)

• Internationalization (18-304)
• Internationalization (29-34)

Flow.Launcher.Core/Resource/Internationalization.cs (1)

Flow.Launcher.Core/Plugin/PluginManager.cs (8)

• PluginManager (24-617)
• PluginManager (139-145)
• Task (87-95)
• Task (97-104)
• Task (106-113)
• Task (115-122)
• Task (164-221)
• Task (238-280)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm

🔇 Additional comments (2)

Flow.Launcher.Core/Resource/Internationalization.cs (2)

99-120: Asynchronous initialization looks solid

The newly introduced InitializeLanguageAsync method cleanly handles fallback to system language, adds plugin language directories, and changes the language. This separation of concerns enhances maintainability and clarity.

---

162-164: Check thread-safety of UpdatePluginMetadataTranslations

await Task.Run(UpdatePluginMetadataTranslations); executes plugin metadata updates on a thread pool thread. Ensure that no UI-bound objects are accessed, and that plugin data structures are thread-safe. Otherwise, consider using the UI thread or synchronization strategies.

Also applies to: 177-177

[gitstream-cm]

🥷 Code experts: no user but you matched threshold 10

Jack251970 has most 👩‍💻 activity in the files.
Jack251970 has most 🧠 knowledge in the files.

See details

Flow.Launcher.Core/Plugin/PluginManager.cs

Activity based on git-commit:

	Jack251970
MAR	0 additions & 3 deletions
FEB	208 additions & 143 deletions
JAN	5 additions & 5 deletions
DEC
NOV	1 additions & 1 deletions
OCT

Knowledge based on git-blame:
Jack251970: 15%

Flow.Launcher.Core/Resource/Internationalization.cs

Activity based on git-commit:

	Jack251970
MAR	67 additions & 40 deletions
FEB	5 additions & 4 deletions
JAN	81 additions & 42 deletions
DEC
NOV	3 additions & 3 deletions
OCT

Knowledge based on git-blame:
Jack251970: 33%

Flow.Launcher/App.xaml.cs

Activity based on git-commit:

	Jack251970
MAR	29 additions & 35 deletions
FEB	79 additions & 40 deletions
JAN	86 additions & 66 deletions
DEC
NOV
OCT

Knowledge based on git-blame:
Jack251970: 43%

To learn more about /:\ gitStream - Visit our Docs

[gitstream-cm]

This PR contains a TODO statement. Please check to see if they should be removed.