Skip to content

Add glyph icons for Sys Plugin #3395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

onesounds
Copy link
Contributor

What's the PR

  • Added glyph icons for Sys Plugin
  • Adjust some glyphs

@onesounds onesounds added the kind/ui related to UI, icons, themes, etc label Mar 28, 2025
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ forbidden-pattern 22
⚠️ non-alpha-in-dictionary 19

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Copy link

gitstream-cm bot commented Mar 28, 2025

🥷 Code experts: Jack251970

Jack251970 has most 👩‍💻 activity in the files.
Jack251970 has most 🧠 knowledge in the files.

See details

Plugins/Flow.Launcher.Plugin.Sys/Main.cs

Activity based on git-commit:

Jack251970
APR 4 additions & 3 deletions
MAR 200 additions & 186 deletions
FEB 98 additions & 56 deletions
JAN
DEC 12 additions & 38 deletions
NOV 12 additions & 14 deletions

Knowledge based on git-blame:
Jack251970: 43%

To learn more about /:\ gitStream - Visit our Docs

Copy link

gitstream-cm bot commented Mar 28, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

Copy link
Contributor

coderabbitai bot commented Mar 28, 2025

📝 Walkthrough

Walkthrough

This update revises the icon glyph codes used in the Commands method of the Sys plugin within Flow Launcher. Several command icons have been adjusted, including changes to the glyphs for "Hibernate", "Empty Recycle Bin", and "Set Flow Launcher Theme". New glyph assignments have been added for commands such as "Exit", "Save Settings", "Restart Flow Launcher", "Settings", "Reload Plugin Data", "Check For Update", "Open Log Location", "Flow Launcher Tips", and "Flow Launcher UserData Folder". The underlying functionality and control flow remain unchanged.

Changes

File Change Summary
Plugins/.../Main.cs Updated Glyph codes for commands: "Hibernate" changed from \xe945 to \xe8be; "Empty Recycle Bin" changed from \xe74d to \xea99; added Glyphs for "Exit" (\xe89f), "Save Settings" (\xea35), "Restart Flow Launcher" (\xe72c), "Settings" (\xf210), "Reload Plugin Data" (\xe72c), "Check For Update" (\xede4), "Open Log Location" (\xf12b), "Flow Launcher Tips" (\xe897), "Flow Launcher UserData Folder" (\xf12b); updated "Set Flow Launcher Theme" from \ue7fc to \ue790.

Suggested labels

enhancement

Suggested reviewers

  • jjw24

Poem

I'm just a little rabbit with a hop so fleet,
Skipping through the code with every line I meet.
New glyphs now sparkle like stars in the night,
Each icon refreshed, oh what a delightful sight!
I munch on carrots and debug with glee—
The flow's now brighter for you and for me!
🐇🥕


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 697fb72 and c2d1b30.

📒 Files selected for processing (1)
  • Plugins/Flow.Launcher.Plugin.Sys/Main.cs (12 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
🔇 Additional comments (12)
Plugins/Flow.Launcher.Plugin.Sys/Main.cs (12)

302-312: Glyph updated for Hibernate command.

The Hibernate command's glyph has been updated from "\xe945" to "\xe8be" which likely represents a more appropriate icon from the Segoe Fluent Icons font.


324-347: Glyph updated for Empty Recycle Bin command.

The Empty Recycle Bin command's glyph has been updated from "\xe74d" to "\xea99" which likely provides a better visual representation that distinguishes it from the Open Recycle Bin command.


360-370: Added glyph for Exit command.

A glyph ("\xe89f") has been added for the Exit command, providing a consistent visual representation alongside other commands.


371-383: Added glyph for Save Settings command.

A glyph ("\xea35") has been added for the Save Settings command, which likely represents a save or disk icon.


384-394: Added glyph for Restart Flow Launcher command.

A glyph ("\xe72c") has been added for the Restart Flow Launcher command, which likely represents a refresh or restart icon.


395-405: Added glyph for Settings command.

A glyph ("\xf210") has been added for the Settings command, which likely represents a gear or settings icon.


406-425: Added glyph for Reload Plugin Data command.

A glyph ("\xe72c") has been added for the Reload Plugin Data command. Note that this is the same glyph used for the Restart Flow Launcher command, which makes sense as both represent refresh/reload actions.


426-437: Added glyph for Check For Update command.

A glyph ("\xede4") has been added for the Check For Update command, which likely represents a download or update icon.


438-450: Added glyph for Open Log Location command.

A glyph ("\xf12b") has been added for the Open Log Location command, which likely represents a folder or document icon.


451-463: Added glyph for Flow Launcher Tips command.

A glyph ("\xe897") has been added for the Flow Launcher Tips command, which likely represents a help, information, or documentation icon.


464-476: Added glyph for Flow Launcher UserData Folder command.

A glyph ("\xf12b") has been added for the Flow Launcher UserData Folder command. This is the same glyph used for the Open Log Location command, which makes sense as both represent folder locations.


488-498: Updated glyph for Set Flow Launcher Theme command.

The Set Flow Launcher Theme command's glyph has been updated from "\ue7fc" to "\ue790", which likely provides a more suitable visual representation for theme selection.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@Jack251970 Jack251970 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jack251970 Jack251970 added this to the 1.20.0 milestone Mar 29, 2025
@onesounds onesounds merged commit e63d7b7 into Flow-Launcher:dev Mar 29, 2025
8 checks passed
@jjw24 jjw24 added the enhancement New feature or request label Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kind/ui related to UI, icons, themes, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants