Skip to content

Organizing the settings page #3400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Mar 30, 2025

What's the PR

image

image

  • Reordered the settings items and changed some items to expandable card type

    • Changed items that were previously shown only when enabled to use expandable sections instead.
  • Replaced the theme creation guide link with the Theme Builder link

  • Fix Padding for InsideFit card

  • Add subtext indicating whether backdrop is available

Test Cases

  • On Windows 10, the subtext of the Backdrop Type should display the message: "This feature is supported starting from Windows 11."
  • This message should update in real-time when the language is changed.

…ard type

- Replaced the theme creation guide link with the Theme Builder link
- Fix Padding for InsideFit card
@prlabeler prlabeler bot added the bug Something isn't working label Mar 30, 2025

This comment has been minimized.

Copy link
Contributor

coderabbitai bot commented Mar 30, 2025

📝 Walkthrough

Walkthrough

This pull request updates several XAML files and one C# file. In the XAML resource file, comma-separated property values have been standardized to space-separated values. Additionally, a ViewModel’s static URL property has been updated to point to a new theme builder page. The settings pages have undergone layout restructuring; one now groups related card elements under a card group, while another replaces traditional cards with an extended card featuring a side content section for toggle switches. These modifications adjust the UI presentation without affecting the underlying application logic.

Changes

File Changes Summary
Flow.Launcher/.../Card.xaml Standardized property formatting in XAML by converting comma-separated values to space-separated values for attributes like Padding, Margin, and BorderThickness.
Flow.Launcher/.../SettingsPaneThemeViewModel.cs Introduced a new computed property BackdropSubText and updated the static URL property LinkHowToCreateTheme to direct users to a new theme builder page.
Flow.Launcher/.../SettingsPaneGeneral.xaml
Flow.Launcher/.../SettingsPaneTheme.xaml
Restructured the settings UI: grouped related <cc:Card> elements into a new <cc:CardGroup> for a clearer layout in one file and replaced several <cc:Card> elements with <cc:ExCard> (including a new <cc:ExCard.SideContent> and added Type="InsideFit") in the other file, improving visual organization.
Flow.Launcher/.../en.xaml Added a new string resource for the tooltip BackdropTypeDisabledToolTip, providing information on the backdrop feature's compatibility with Windows versions.

Suggested labels

enhancement, Dev branch only

Suggested reviewers

  • jjw24

Poem

I'm a rabbit, quick on my feet,
Hopping through code with a joyful beat,
Formatting tweaks and UI refined,
URLs and groups in perfect design,
With every change I cheer and leap,
Celebrating progress, a harvest to keep!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a35fb34 and 6b6aaa1.

📒 Files selected for processing (3)
  • Flow.Launcher/Languages/en.xaml (1 hunks)
  • Flow.Launcher/SettingPages/ViewModels/SettingsPaneThemeViewModel.cs (1 hunks)
  • Flow.Launcher/SettingPages/Views/SettingsPaneTheme.xaml (6 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Flow.Launcher/SettingPages/ViewModels/SettingsPaneThemeViewModel.cs
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: gitStream.cm
🔇 Additional comments (7)
Flow.Launcher/Languages/en.xaml (1)

199-199: Good addition of the new tooltip string.
This new resource clarifies the Windows 11 requirement for the backdrop feature, improving user awareness without introducing any conflicts.

Flow.Launcher/SettingPages/Views/SettingsPaneTheme.xaml (6)

471-472: Binding the BackdropSubText property.
The added Icon property and the Sub binding to BackdropSubText correctly provide contextual information and remain consistent with the new tooltip string resource.


503-515: Adopting ExCard for keep-max-results setting.
Switching from standard Card to ExCard with Type="InsideFit" is coherent with the new card layout pattern. The toggle switch approach for enabling/disabling the fixed window size is straightforward and well-structured.

Also applies to: 519-525


572-594: Introducing placeholder text configuration.
The new ExCard and nested Card consistently follow the updated layout pattern. Allowing the user to toggle the placeholder and customize its text is a clear UI improvement.


595-631: Refactoring animation settings into an ExCard.
The two-tier structure (toggle switch plus an inner card) cleanly separates enabling animation from setting its speed, enhancing clarity for users.


633-665: Sound effect settings in a new extended card.
Combining the toggle with an inner Card for volume control provides a uniform user experience. No concerns regarding functionality or naming.


701-712: Adding a new card for glyph icons.
This addition follows the ExCard-based layout, clearly presenting the toggle for using Segoe Fluent Icons. It aligns well with the rest of the settings structure.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@onesounds onesounds added kind/ui related to UI, icons, themes, etc 5 min review and removed bug Something isn't working labels Mar 30, 2025
@onesounds onesounds enabled auto-merge March 30, 2025 08:23
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ forbidden-pattern 22
⚠️ non-alpha-in-dictionary 19

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@prlabeler prlabeler bot added bug Something isn't working enhancement New feature or request labels Mar 31, 2025
@onesounds onesounds requested a review from Jack251970 March 31, 2025 10:47
@onesounds onesounds merged commit 0e4e95a into Flow-Launcher:dev Mar 31, 2025
6 checks passed
@Jack251970 Jack251970 added this to the 1.20.0 milestone Mar 31, 2025
Copy link

gitstream-cm bot commented Mar 31, 2025

🥷 Code experts: Jack251970, Yusyuriv

onesounds, Jack251970 have most 👩‍💻 activity in the files.
onesounds, Yusyuriv have most 🧠 knowledge in the files.

See details

Flow.Launcher/Languages/en.xaml

Activity based on git-commit:

onesounds Jack251970
APR 9 additions & 1 deletions
MAR 8 additions & 3 deletions 67 additions & 42 deletions
FEB 15 additions & 9 deletions
JAN 1 additions & 0 deletions
DEC
NOV

Knowledge based on git-blame:
onesounds: 40%
Yusyuriv: 5%

Flow.Launcher/Resources/Controls/Card.xaml

Activity based on git-commit:

onesounds Jack251970
APR
MAR 13 additions & 13 deletions
FEB
JAN
DEC
NOV

Knowledge based on git-blame:
onesounds: 85%
Yusyuriv: 15%

Flow.Launcher/SettingPages/ViewModels/SettingsPaneThemeViewModel.cs

Activity based on git-commit:

onesounds Jack251970
APR
MAR 155 additions & 87 deletions 111 additions & 111 deletions
FEB 2 additions & 0 deletions 2 additions & 21 deletions
JAN 1 additions & 1 deletions
DEC
NOV 2 additions & 2 deletions

Knowledge based on git-blame:
Yusyuriv: 53%
onesounds: 24%

Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml

Activity based on git-commit:

onesounds Jack251970
APR
MAR 43 additions & 62 deletions 44 additions & 20 deletions
FEB 1 additions & 1 deletions
JAN 8 additions & 1 deletions
DEC
NOV

Knowledge based on git-blame:
onesounds: 67%
Yusyuriv: 33%

Flow.Launcher/SettingPages/Views/SettingsPaneTheme.xaml

Activity based on git-commit:

onesounds Jack251970
APR
MAR 174 additions & 149 deletions 62 additions & 35 deletions
FEB
JAN
DEC
NOV

Knowledge based on git-blame:
onesounds: 80%
Yusyuriv: 18%

To learn more about /:\ gitStream - Visit our Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kind/ui related to UI, icons, themes, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants