Skip to content

Migrate npm to yarn#22

Draft
nguyyentantai wants to merge 4 commits intomainfrom
migrate-npm-to-yarn
Draft

Migrate npm to yarn#22
nguyyentantai wants to merge 4 commits intomainfrom
migrate-npm-to-yarn

Conversation

@nguyyentantai
Copy link
Copy Markdown
Collaborator

@nguyyentantai nguyyentantai commented Aug 2, 2022 •
edited
Loading

Make it better everywhere

lamnguyencse17
lamnguyencse17 requested changes Aug 2, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lamnguyencse17 lamnguyencse17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that CI are able to run and deploy (it is using npm)

@nguyyentantai nguyyentantai marked this pull request as draft August 2, 2022 16:06
@nguyyentantai
Copy link
Copy Markdown
Collaborator Author

nguyyentantai commented Aug 2, 2022 •
edited
Loading

Please make sure that CI are able to run and deploy (it is using npm)

@lamnguyencse17 hmm 🤔

@lamnguyencse17
Copy link
Copy Markdown
Collaborator

lamnguyencse17 commented Aug 2, 2022 •
edited
Loading

As discussed, there is an on-going UI library bugs that prevents this from happening. Therefore this pr will be halted

@nguyyentantai nguyyentantai added the do-not-merge This issue or pull request still in progress label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lamnguyencse17 lamnguyencse17 lamnguyencse17 requested changes

Assignees

No one assigned

Labels

do-not-merge This issue or pull request still in progress pending

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nguyyentantai @lamnguyencse17