[16.0][FIX] rma, add support to handle package used on customer moves #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PauBForgeFlow
force-pushed
the
16.0-fix-package-cases
branch
from
d0df9bf to
ed9360a
Compare
AaronHForgeFlow
force-pushed
the
16.0-fix-package-cases
branch
from
ed9360a to
d5db071
Compare
Contributor
|
Rebased. Conflicts avoided but still not working. |
AlexPForgeFlow
force-pushed
the
16.0-fix-package-cases
branch
4 times, most recently
from
910ee85 to
55ccd74
Compare
cormaza
reviewed
Oct 22, 2024
rma/hooks.py
Outdated
| if ( | ||
| pack.package_use == "disposable" | ||
| and pack.location_id | ||
| != self.env.ref("stock.stock_location_customers") |
There was a problem hiding this comment.
should compare with usage field, pack.location_id.usage != 'customer'
ArnauCForgeFlow
force-pushed
the
16.0-fix-package-cases
branch
from
0cfba0a to
941dc41
Compare
ArnauCForgeFlow
force-pushed
the
16.0-fix-package-cases
branch
from
941dc41 to
dd78212
Compare
ChrisOForgeFlow
force-pushed
the
16.0-fix-package-cases
branch
from
8db299c to
a8184e9
Compare
Contributor
|
For reference, fwport to v17 was already done in #499 and it was included in v18 migration. No need to port anything if this gets merged. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from #493