Open
Conversation
chore: fix-fork-ci
…-type fix(ping-protect): fixes type for PIProtect.start() options object
|
View your CI Pipeline Execution ↗ for commit bd0ed84
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #576 +/- ##
=========================================
Coverage ? 58.62%
=========================================
Files ? 105
Lines ? 31607
Branches ? 1963
=========================================
Hits ? 18531
Misses ? 13076
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
feat: add auto complete ui for AM-33773
github-actions
bot
force-pushed
the
changeset-release/master
branch
from
bd0ed84 to
a122d6e
Compare
…from blocking CI The release publish workflow failed because the Slack payload contained unescaped multi-line mrkdwn content that broke the webhook action's parser. This caused code coverage to be skipped since the job halted on the Slack error. - Build a proper JSON payload via jq instead of raw string interpolation - Use env vars for changesets output to avoid command injection - Add continue-on-error to Slack steps so notifications never block the pipeline
- Snapshot job now reads package.json files to build a real payload instead of hardcoding empty publishedPackages - Both jobs use the same jq-based JSON payload construction - Add warning annotations when Slack notifications fail so failures are visible in the Actions summary without blocking the pipeline
Fixes a security vulnerability where evaluateUrlForInterception used .includes() for URL matching, allowing allow-list bypass via query parameter injection (e.g. https://evil.com?https://valid.com). Replaces .includes() with === for exact string comparison. Blob URLs now require explicit wildcard patterns (blob:https://origin/*). Also removes @forgerock/token-vault from changeset ignore list to enable re-release.
Only include packages whose version contains the snapshot tag, so packages in the changeset ignore list (e.g. token-vault) that keep their stable version are excluded from the notification.
fix(ci): fix slack payload parsing in release workflow
github-actions
bot
force-pushed
the
changeset-release/master
branch
from
a122d6e to
79b8857
Compare
fix(token-vault): replace substring URL matching with strict equality
github-actions
bot
force-pushed
the
changeset-release/master
branch
from
79b8857 to
8ecb532
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.
Releases
@forgerock/javascript-sdk@4.9.0
Minor Changes
03135cfThanks @cameronwhitworthforgerock! - Added support for Conditional UI elements with WebAuthN@forgerock/ping-protect@4.6.3
Patch Changes
#575
8ccfef4Thanks @ryanbas21! - fixes the type of the options param inPIProtect.startso it better aligns with output fromPingOneProtectInitializeCallback.getConfig()as defined injavascript-sdk(importantly it no longer expects_typeand_actionfields)Updated dependencies [
03135cf]:@forgerock/token-vault@4.2.1
Patch Changes
#580
d319384Thanks @ryanbas21! - fix(security): replace substring URL matching with strict equality in evaluateUrlForInterception to prevent URL allow-list bypass via query parameter injectionUpdated dependencies [
03135cf]:Security: - Proxy config declaring URLs is now required and will be used to generate an allow list of origins to check again prior to fowarding a request.