feat(ci): add StackBlitz templates for e2e apps#540
Conversation
Adds --template flag to pkg-pr-new so PR comments include interactive StackBlitz links for all e2e apps. Also switches to --pnpm for correct packing in the monorepo.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CI workflow's publish step was updated to include two additional arguments: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 5615d50
☁️ Nx Cloud last updated this comment at |
More templates
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
|
Deployed f10f86b to https://ForgeRock.github.io/ping-javascript-sdk/pr-540/f10f86be4f11d4194b57445e42f7814181a62031 branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/journey-client - 0.0 KB (-87.4 KB, -100.0%) 📊 Minor Changes📉 @forgerock/journey-client - 87.3 KB (-0.0 KB) ➖ No Changes➖ @forgerock/sdk-logger - 1.6 KB 13 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (14.75%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #540 +/- ##
==========================================
- Coverage 18.79% 14.75% -4.05%
==========================================
Files 140 153 +13
Lines 27640 26265 -1375
Branches 980 1054 +74
==========================================
- Hits 5195 3875 -1320
+ Misses 22445 22390 -55 🚀 New features to boost your workflow:
|
|
How are the templates useful? Is the idea so that we can copy paste the package.json into our e2e locally so we can run the test suites? Also, the templates generated by Stackblitz don't seem to boot up the application in the browser. There might be some error I'm not seeing. |
Summary
--template './e2e/*-app'topkg-pr-newso PR comments include interactive StackBlitz links for all e2e apps (davinci, journey, oidc, device-client, protect)--pnpmflag for correctpnpm packbehavior in the monorepo--packageManager=pnpmso PR comments showpnpm addinstall commandsTest plan
pnpm packis used (check CI logs for pack output)Summary by CodeRabbit