Skip to content

Update changeset and CI#542

Merged
ancheetah merged 2 commits intomainfrom
update-changeset-and-ci
Mar 2, 2026
Merged

Update changeset and CI#542
ancheetah merged 2 commits intomainfrom
update-changeset-and-ci

Conversation

@ancheetah
Copy link
Collaborator

@ancheetah ancheetah commented Mar 2, 2026

JIRA Ticket

Description

  • Removes out of date snippet for journey client initialization
  • Fixes pnpm packing for Stackblitz publishes

Summary by CodeRabbit

  • Documentation
    • Simplified OIDC endpoint discovery documentation for the journey-client, replacing a multi-line configuration example with a concise inline description.

@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2026

⚠️ No Changeset found

Latest commit: 2fb5a2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 12 packages
Name Type
@forgerock/journey-client Minor
@forgerock/sdk-oidc Minor
@forgerock/sdk-utilities Minor
@forgerock/davinci-client Minor
@forgerock/oidc-client Minor
@forgerock/device-client Minor
@forgerock/protect Minor
@forgerock/sdk-types Minor
@forgerock/iframe-manager Minor
@forgerock/sdk-logger Minor
@forgerock/sdk-request-middleware Minor
@forgerock/storage Minor

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 91d5ce0 and 2fb5a2f.

📒 Files selected for processing (3)
  • .changeset/rich-cows-try.md
  • .github/actions/publish-beta/action.yml
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

Documentation is simplified for journey-client OIDC endpoint discovery, and CI/CD publish commands are augmented with an additional --pnpm flag alongside the existing --packageManager=pnpm parameter in both GitHub Actions and workflows.

Changes

Cohort / File(s) Summary
Documentation
.changeset/rich-cows-try.md
Removed multi-line example configuration block and explanatory paragraph; replaced with single inline sentence describing journey-client OIDC endpoint discovery capability and realm path inference.
CI/CD Configuration
.github/actions/publish-beta/action.yml, .github/workflows/ci.yml
Added --pnpm flag to pnpm pkg-pr-new publish commands alongside existing --packageManager=pnpm parameter.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • ryanbas21
  • cerebrl

Poem

🐰 ✨
A changelog trimmed with care,
Flags now aligned without despair,
Pnpm publishes with flair!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update changeset and CI' is vague and generic, using non-descriptive terms that don't clearly convey the specific changes made. Make the title more specific, such as 'Remove outdated journey-client snippet and fix pnpm publishing for Stackblitz' to clearly indicate the main changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description includes both required sections and provides clear bullet points explaining the changes, though the JIRA Ticket section is empty.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-changeset-and-ci

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Mar 2, 2026

View your CI Pipeline Execution ↗ for commit 2fb5a2f

Command Status Duration Result
nx run-many -t build --no-agents ✅ Succeeded <1s View ↗
nx affected -t build lint test typecheck e2e-ci ✅ Succeeded 5m 36s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-02 20:09:05 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 2, 2026

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/davinci-client@542

@forgerock/device-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/device-client@542

@forgerock/journey-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/journey-client@542

@forgerock/oidc-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/oidc-client@542

@forgerock/protect

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/protect@542

@forgerock/sdk-types

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-types@542

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-utilities@542

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/iframe-manager@542

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-logger@542

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-oidc@542

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-request-middleware@542

@forgerock/storage

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/storage@542

commit: 2fb5a2f

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

Deployed 7be7623 to https://ForgeRock.github.io/ping-javascript-sdk/pr-542/7be7623ebb41eb67e5b39a0f5e1f8f006324d216 branch gh-pages in ForgeRock/ping-javascript-sdk

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🆕 New Packages

🆕 @forgerock/journey-client - 87.3 KB (new)
🆕 @forgerock/journey-client - 0.0 KB (new)

➖ No Changes

@forgerock/sdk-logger - 1.6 KB
@forgerock/sdk-request-middleware - 4.5 KB
@forgerock/iframe-manager - 2.4 KB
@forgerock/sdk-oidc - 4.8 KB
@forgerock/storage - 1.5 KB
@forgerock/sdk-types - 7.9 KB
@forgerock/protect - 150.1 KB
@forgerock/device-client - 9.2 KB
@forgerock/davinci-client - 41.3 KB
@forgerock/sdk-utilities - 11.2 KB
@forgerock/oidc-client - 24.9 KB


13 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated
  • Current Size: Total gzipped size of all files in the package's dist directory
  • Baseline: Comparison against the latest build from the main branch
  • Files included: All build outputs except source maps and TypeScript build cache
  • Exclusions: .map, .tsbuildinfo, and .d.ts.map files

🔄 Updated automatically on each push to this PR

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.75%. Comparing base (b89ad58) to head (2fb5a2f).
⚠️ Report is 52 commits behind head on main.

❌ Your project status has failed because the head coverage (14.75%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
- Coverage   18.79%   14.75%   -4.05%     
==========================================
  Files         140      153      +13     
  Lines       27640    26265    -1375     
  Branches      980     1054      +74     
==========================================
- Hits         5195     3875    -1320     
+ Misses      22445    22390      -55     

see 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ancheetah ancheetah merged commit 8ea79b4 into main Mar 2, 2026
8 checks passed
@ancheetah ancheetah deleted the update-changeset-and-ci branch March 2, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants