Compatibility v13 by WebMaestroFr · Pull Request #48 · ForgeVTT/forge-compendium-browser

WebMaestroFr · 2025-12-02T07:54:01Z

⚠️ I merged #41 to main by mistake when creating this branch. The only thing I managed to revert was the git history somehow, but the changes are still on there.

…ForgeVTT/forge-compendium-browser

…ium-browser

zeel01

Looks good for the most part, but I think we need to clean up the console output. If something is really important for debugging we should prefer console.debug() as the verbose log level if nothing is going wrong. I was going to suggest we could use the log levels from https://foundryvtt.com/packages/_dev-mode but it seems to not have been updated past v9...

zeel01 · 2025-12-19T15:00:30Z

src/apps/compendium-browser-app.js

+        async _prepareContext(options) {
+            console.warn("CompendiumBrowserApp._prepareContext", options);
+            const context = await super._prepareContext(options);
+            return context;
+        }
+
+        _onRender(context, options) {
+            console.warn("CompendiumBrowserApp._onRender", context, options);


Should these console warnings remain in the code?

zeel01 · 2025-12-19T15:01:05Z

src/apps/compendium-browser-app.js

+export class CompendiumBrowserApp extends CompendiumBrowserAppBase {
    constructor(book, options = {}) {
-        super(null, options);
+        console.warn("CompendiumBrowserApp.constructor", book, options);


zeel01 · 2025-12-19T15:02:25Z

src/forge-compendium-browser.js

    }

    static async onMessage(data) {
+        console.warn("ForgeCompendiumBrowser.openBrowser", data);


zeel01 · 2025-12-19T15:02:33Z

src/forge-compendium-browser.js

    }

    static openBrowser(book) {
+        console.warn("ForgeCompendiumBrowser.openBrowser", book);


Eranziel

A good start! Still needs some work, could be done in a follow-up PR.

Light mode CSS is borked.
Actor sheets don't render in a usable way.
Item sheets don't render in a usable way.
Journals don't render. (Vanilla journal show behind compendium browser window.)

module.json

Eranziel · 2025-12-22T17:00:08Z

src/apps/compendium-browser-app.js


-export class CompendiumBrowserApp extends Application {
+let CompendiumBrowserAppBase;
+if (foundry?.applications?.api?.ApplicationV2) {


I don't think it's worth putting ourselves through knots to maintain AppV1 compatibility here. I think we should just use AppV2 and set min compatibility to v12.

- Improved code organization - Made rendering compatible with v13 applications - Made rendering compatible with new 5e system

…ame" element instead.

zeel01 · 2026-02-19T05:25:09Z

Substantially refactored some portions of the code for entries. Partially because it needed cleaned up, but mainly because the process of refactoring it let me learn how it worked and update it for v13.
Light and dark mode are now both supported
Actor and Item sheets render correctly inside the app
Journal sheets render correctly inside the app
Imports now work
DNDB compendiums are correctly hidden from the sidebar

zeel01 · 2026-02-19T05:46:39Z

@qalucaspacheco1 QA notes:

Install dependencies: dlopen, vueport
Install package via import wizard: forge-compendium-browser.zip
The previous verified compatibility for this module was v11, so we primarily want to know if there are any regressions between the published version in v11 and this new version in v13.
The v11 version does work in v12 but has a few issues. This v13 version is not compatible with older versions of Foundry. I have not tested it on v14.
Neither of the dndb basic rules packs contain any scenes, you will need to import a dndb module that has scenes to test that part. I'm not sure how you can do that on QA unless you own a book with maps.

Eranziel · 2026-03-05T19:57:43Z

Neither of the dndb basic rules packs contain any scenes, you will need to import a dndb module that has scenes to test that part. I'm not sure how you can do that on QA unless you own a book with maps.

I think Intro to Stormwreck Isle can be imported for free, and it has a couple scenes.

Eranziel

A few comments and nit-picks, shouldn't be anything major. The main thing remaining is putting this through QA.

Eranziel · 2026-03-05T19:54:00Z

src/apps/compendium-browser-app.js

+    }
+}
+
+export class CompendiumBrowserApp extends CompendiumBrowserAppBase {


Is there a reason CompendiumBrowserApp and CompendiumBrowserAppBase are still separate? Do we anticipate a need to extend the latter for a different app in the future?

Eranziel · 2026-03-05T19:56:23Z

src/components/CompendiumEntry.vue

+  computed: {
+    documentClasses() {
+      const classes = this.subsheet?.options?.classes || [];
+      // if (game.version.startsWith("10.")) classes.push("v10");


Commented code still needed?

Eranziel · 2026-03-05T19:59:04Z

src/components/CompendiumEntry.vue

+      const stats = {};
+
+      for (const collection of ["drawings", "lights", "notes", "sounds", "tiles", "tokens", "walls"]) {
+        const collectionData = foundry.utils.isNewerVersion(game.version, "9.99999")


This version check can be removed, since minimum compatibility is v13 now.

Eranziel · 2026-03-05T19:59:27Z

src/components/CompendiumEntry.vue

+          // this.subsheet._state = this.subsheet.constructor.RENDER_STATES.RENDERING;
+          // const templateData = await (
+          //   typeof this.subsheet._prepareContext === "function"
+          //     ? this.subsheet._prepareContext()


Commented code still needed?

Eranziel · 2026-03-05T20:01:04Z

src/forge-compendium-browser.js

    }

    static async onMessage(data) {
+        console.debug("ForgeCompendiumBrowser.openBrowser", data);


Typo

Suggested change

console.debug("ForgeCompendiumBrowser.openBrowser", data);

console.debug("ForgeCompendiumBrowser.onMessage", data);

Eranziel · 2026-03-05T20:02:14Z

module.json

-  "version": "1.5.0",
-  "minimumCoreVersion": "9",
-  "compatibleCoreVersion": "12",
+  "version": "1.7.0",


Suggested change

"version": "1.7.0",

"version": "1.6.0",

WebMaestroFr and others added 5 commits June 10, 2024 09:33

Set globals for ESLint, clean and fix errors

4075301

Fix build command

ed1f973

Fix warnings

f0335a7

Merge branches 'main' and '2024-06-08-eslint-prettier' of github.com:…

2e26998

…ForgeVTT/forge-compendium-browser

Merge branch 'v12-compatibility' of github.com:ForgeVTT/forge-compend…

b34cdb8

…ium-browser

WebMaestroFr self-assigned this Dec 2, 2025

WebMaestroFr added 5 commits December 2, 2025 15:00

Fix CSS syntax error

b17cd7d

WIP Use ApplicationV2

52bcb06

Revert formatting changes on Vue components

30ab425

Improve retro-compatibility with <v12

208b1d5

Clean up

07c5e26

WebMaestroFr linked an issue Dec 10, 2025 that may be closed by this pull request

Update Compendium Library to v13 / dnd5e v5 #49

Open

Fix Compendium browser

2265779

WebMaestroFr marked this pull request as ready for review December 19, 2025 08:09

WebMaestroFr requested review from Eranziel and zeel01 December 19, 2025 08:09

zeel01 requested changes Dec 19, 2025

View reviewed changes

Eranziel requested changes Dec 22, 2025

View reviewed changes

zeel01 added 12 commits February 17, 2026 21:11

Updated the code to hide compendium entries in the sidebar

6ba6a81

Removed older version of base app

b25f3ee

Added support for dark mode

c4273ac

Refactored inner document rendering flow.

e17c82c

- Improved code organization - Made rendering compatible with v13 applications - Made rendering compatible with new 5e system

Added development section to Readme

990a771

Removed redundant classes from wrapper, classes are needed on the "fr…

9f32c4f

…ame" element instead.

Adjusted general alignments and styles

1a89783

Updated the way sub-document sheets are displayed within the app.

dd9bc1d

Made listing group background contrast better in dark mode

477e669

Removed some more jquery from the scene section

bbc0b11

Fixed imports

7f0b922

Fixed item tabs

a445a81

zeel01 added 4 commits February 18, 2026 23:57

Made breadcrumb bar text size consistent with previous version

71ae717

Tweaked the display of sub-document sheets

717b273

Replaced some warnings with debug output instead

a9e59c3

Updated package manifest

f880a30

zeel01 requested a review from Eranziel February 19, 2026 05:21

Modified readme

cbb3765

This was linked to issues Feb 19, 2026

Ver 13 compat. #46

Closed

Compendium Browser Entries Empty for Imported Module #50

Closed

Project dead? #47

Closed

zgrimshell requested review from vabs and wyrmisis February 23, 2026 16:08

zeel01 added the QA Task label Mar 2, 2026

zeel01 self-requested a review March 3, 2026 23:54

Eranziel requested changes Mar 5, 2026

View reviewed changes

Eranziel assigned zeel01 and unassigned WebMaestroFr Mar 5, 2026

	console.debug("ForgeCompendiumBrowser.openBrowser", data);
	console.debug("ForgeCompendiumBrowser.onMessage", data);

Conversation

WebMaestroFr commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zeel01 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Eranziel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zeel01 commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zeel01 commented Feb 19, 2026

Uh oh!

Eranziel commented Mar 5, 2026

Uh oh!

Eranziel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

WebMaestroFr commented Dec 2, 2025 •

edited

Loading

zeel01 commented Feb 19, 2026 •

edited

Loading