Add timelapse preview to file browser#669
Open
ssendev wants to merge 1 commit intoFormerLurker:develfrom
Open
Conversation
Owner
|
Cool! I will check this out asap. |
Owner
|
Question: What formats does the player support? I see you have reused the OctoPrint player template, which isn't working for the default video type for me (.mp4) for some reason. |
Author
|
It depends on your browser H264 is supported by most |
|
Owner
|
I'm going to reexamine this PR ASAP. Working on a new release, so it's a good time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation copied from
https://github.com/OctoPrint/OctoPrint/blob/f67c15a9a47794a68be9aed4f2d5a12a87e70179/src/octoprint/static/js/app/viewmodels/timelapse.js#L308-L318
https://github.com/OctoPrint/OctoPrint/blob/f67c15a9a47794a68be9aed4f2d5a12a87e70179/src/octoprint/templates/dialogs/timelapse.jinja2
There were some access checks in the original file browser which the download in Octolapse didn't have so i didn't add one to the preview
also there were quite some variations for
function() {so i choose my preferred style