Skip to content

Conversation

@jguegel
Copy link
Contributor

@jguegel jguegel commented Dec 11, 2025

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • added argument for thirdPartyIntent to use tracks.toMediaItems instead of tracks.toMediaItemsFast()

Tests performed

  • run with file from from .nomedia folder and "normal" file with logoutput
image

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

@jguegel jguegel requested a review from naveensingh as a code owner December 11, 2025 13:44
@naveensingh naveensingh changed the title Fix Can't play files from directories with ".nomedia" 114 fix: allow playing files from directories with ".nomedia" Dec 11, 2025
Copy link
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the immediate problem, but:

  • It's not fixing the problem at the source. The media item (from toMediaItemsFast()) should be resolved properly on the service side, even if it is from a third-party intent.
  • Close or reopen the app and resume leads to an unknown error. Same if I press next/previous.

@naveensingh naveensingh added the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Dec 12, 2025
@jguegel
Copy link
Contributor Author

jguegel commented Dec 12, 2025

@naveensingh
which next/previous are you clicking?
ignoreImageMinify

@naveensingh
Copy link
Member

naveensingh commented Dec 12, 2025

Open file ➜ Pause playback ➜ Press back twice ➜ Reopen app ➜ Resume or press next/previous (it'll be visible now).

@jguegel
Copy link
Contributor Author

jguegel commented Dec 14, 2025

#115 would be fixed. about #114 i am still trying to figure out a method

@jguegel
Copy link
Contributor Author

jguegel commented Dec 14, 2025

@naveensingh @Aga-C about #115
seems to be fixed. I still receive IllegalArgumentException toast, but no stacktrace.
if you have an idea, please point me in the direction

@jguegel jguegel requested a review from naveensingh December 14, 2025 20:23
@naveensingh
Copy link
Member

I'll check it

@naveensingh naveensingh removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't open unscanned files via intent Can't play files from directories with ".nomedia"

2 participants