FDBRecordStore.scanTypedRecords would skip double records on a store using splitLongRecords
#3525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangmaihuy
force-pushed
the
fix-scan-records-skip
branch
from
4e5a792 to
5f8a74e
Compare
alecgrieser
requested changes
Aug 14, 2025
| @@ -1322,7 +1322,7 @@ public <M extends Message> RecordCursor<FDBStoredRecord<M>> scanTypedRecords(@No | |||
| .setContext(context).setContinuation(continuation) | |||
| .setLow(low, lowEndpoint) | |||
| .setHigh(high, highEndpoint) | |||
| .setScanProperties(scanProperties.with(ExecuteProperties::clearRowAndTimeLimits).with(ExecuteProperties::clearState)) | |||
| .setScanProperties(scanProperties.with(ExecuteProperties::clearRowAndTimeLimits).with(ExecuteProperties::clearSkipAndLimit).with(ExecuteProperties::clearState)) | |||
There was a problem hiding this comment.
We should probably add a test for this that shows that the skip was being incorrectly skipped before (and now works)
There was a problem hiding this comment.
@alecgrieser I've added a test case in FDBRecordStoreSplitRecordsTest, please recheck 😄
…ble records on store using splitLongRecords
hoangmaihuy
force-pushed
the
fix-scan-records-skip
branch
from
5f8a74e to
70023e5
Compare
alecgrieser
approved these changes
Aug 22, 2025
alecgrieser
changed the title
splitLongRecords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear skip when scanning key values as mentioned in issues.