Add support for MDC context passing into the throttled iterator #3740
+90
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottDugas
requested changes
Nov 12, 2025
...e/foundationdb/record/provider/foundationdb/runners/throttled/ThrottledRetryingIterator.java
Outdated
Show resolved
Hide resolved
...apple/foundationdb/record/provider/foundationdb/runners/throttled/ThrottledIteratorTest.java
Show resolved
Hide resolved
...apple/foundationdb/record/provider/foundationdb/runners/throttled/ThrottledIteratorTest.java
Show resolved
Hide resolved
… and placed configuration insode build()
… and placed configuration insode build()
ScottDugas
requested changes
Nov 14, 2025
| * @return the newly minted iterator | ||
| */ | ||
| public ThrottledRetryingIterator<T> build() { | ||
| this.transactionalRunner = new TransactionalRunner(database, contextConfigBuilder); |
Collaborator
There was a problem hiding this comment.
If the constructor that takes a TransactionalRunner is called, the one provided will not be used here.
That call does not appear to be used, maybe worth just deleting.
Contributor
Author
There was a problem hiding this comment.
Yeah, deleted (should have been deleted earlier).
| this.contextConfigBuilder = contextConfigBuilder; | ||
| this.cursorCreator = cursorCreator; | ||
| this.singleItemHandler = singleItemHandler; | ||
| // set defaults |
Collaborator
There was a problem hiding this comment.
I suggest below that you remove the other constructor, but if not, perhaps worth settings these ones in the field declaration, and remove the duplication.
Contributor
Author
There was a problem hiding this comment.
Yes, the other constructor should have been deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MDC context to the throttled iterator:
Resolves #3739