Introduce Serialization format for DataInKeySpacePath #3747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also added `equals` to the KeySpacePath implementation to describe how two KeySpacePaths should be equal
Ideally this would be called when you call `KeySpacePath.add`, but, since we've never had this validation, I'm scared that adding it would break someone's production environment, and so I want to limit it to the new feature. Later we can rollout this validation universally in a controlled fashion.
`ANY_VALUE` should use reference equality, but it also doesn't override .equals so this doesn't really make a difference, but is less surprising to readers. The comparison in the logging was unnecessary, the toString for `ANY_VALUE` is `*any*` which works just as well.
ScottDugas
force-pushed
the
data-in-keyspace-proto
branch
from
cc5ee59 to
b155824
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
KeySpacePathSerializerthat supports serializingDataInKeySpacePath.In addition, I discovered that
KeySpacePathdoesn't actually validate the values being added.I thought about adding the validation to the add method, but felt that was too risky, but I added the validation to the deserialization. This means that if you are currently using
KeySpacePathwith incorrect values, you may not be able to import the data. See: #3746Resolves: #3745