Quote identifier components in toString() #3764
Open
+23
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identifier.toString() now wraps each component with double quotes, making error messages more consistent with SQL identifier syntax and improving readability.
alecgrieser
reviewed
Nov 18, 2025
Comment on lines
+64
to
+67
| .map(q -> "\"" + q + "\"") | ||
| .collect(Collectors.joining(".")) | ||
| + (qualifier.isEmpty() ? "" : ".") | ||
| + "\"" + name + "\""; |
Collaborator
There was a problem hiding this comment.
Using double quotes in error messages can lead to problems when integrating with logging frameworks. For example, if the user prints out the error message to a logging system with key-value pairs of quoted keys and values, then the internal quote within the message can end up confusing things. We could get around this by using single quotes (or backticks), though that is different from what the SQL query coming in will do
alecgrieser
reviewed
Nov 18, 2025
| "CREATE INDEX mv1 AS SELECT X.col2, \"__ROW_VERSION\" FROM T1, (SELECT col2 FROM T1.A) X ORDER BY X.col2, \"__ROW_VERSION\" " + | ||
| "WITH OPTIONS(store_row_versions=true)"; | ||
| shouldFailWith(stmt, ErrorCode.AMBIGUOUS_COLUMN, "Ambiguous reference '__ROW_VERSION'"); | ||
| shouldFailWith(stmt, ErrorCode.AMBIGUOUS_COLUMN, "Ambiguous reference '\"__ROW_VERSION\"'"); |
Collaborator
There was a problem hiding this comment.
Should we update "Ambiguous reference" to remove the single quotes like was done with "Attempting to query non existing column"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Identifier.toString() to wrap components with double quotes, making error messages consistent with SQL identifier syntax and improving readability.