Merged
Conversation
- Update GetTrailerInfo API endpoint to use BaseItem instead of Movie - Use IHasTrailers interface for trailer detection (works with Movies and Series) - Update client script selectors to include Series cards - Update MutationObserver to detect Series card additions - Rename movieId parameter to itemId for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12 - Series now display trailer previews on hover, just like Movies.
Problem
Users reported that hovering over Series cards did not trigger trailer previews, even though trailers existed and worked when clicking the trailer button directly in Jellyfin.
Changes
BaseItemandIHasTrailersinterface instead of Movie type, enabling trailer detection for any item that supports trailersmovieIdtoitemIdthroughout for clarityTesting