Align with LangChain integration standards#5
Merged
loookashow merged 5 commits intomainfrom Mar 23, 2026
Merged
Conversation
- Restructure tests into unit_tests/ and integration_tests/ per LangChain convention - Add langchain-tests standard suite (RetrieversIntegrationTests) - Add test_imports.py for public API validation - Add runtime top_k override support in retriever (required by standard tests) - Add mypy type checking with disallow_untyped_defs - Update CI workflow: mypy in lint, integration test job on push to main - Update pyproject.toml: pinned langchain-tests, project URLs, mypy config - Update Makefile: unit/integration test separation, --disable-socket - Update CONTRIBUTING.md with new test paths
Vector search and vector_field_search did not pass top_k as the default limit, unlike text and hybrid modes. This caused the API to return all matching results instead of respecting the requested count. Also tune integration test params for the live test dataset.
- Add "Verify required secrets" pre-step in CI integration job to fail fast when env vars are missing (prevents false-green) - Add sync/async tests for runtime k alias (invoke/ainvoke with k=N) - Add sync/async tests for k + top_k dual-arg conflict (ValueError)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unit_tests/andintegration_tests/per LangChain partner conventionslangchain-testsstandard suite (RetrieversIntegrationTests) with env-var skip guardstop_k/koverride support ininvoke()/ainvoke()(required by standard tests)limittotop_ktest_imports.py, CI integration job with secrets verificationTest plan
make lint— ruff + mypy passmake test— 187 unit tests pass with--disable-socketmake integration_test— 8 standard + live tests pass (requires FoxNose credentials)