Skip to content

Conversation

@knoepfel
Copy link
Member

@knoepfel knoepfel commented Jan 7, 2026

The fmt::format(...) function can represent a Boost JSON string as an array of chars instead of character string (e.g.):"

Both 'cpp' and 'py' parameters specified for malformed3
    - cpp: ['m', 'y', '_', 'o', 't', 'h', 'e', 'r', '_', 'p', 'y', 't', 'h', 'o', 'n', '_', 'p', 'h', 'l', 'e', 'x', '_', 'm', 'o', 'd', 'u', 'l', 'e']

This PR makes use of Boost JSON string's implicit conversion operator to std::string_view so that fmt::format(...) will form the output correctly (e.g.):

Both 'cpp' and 'py' parameters specified for malformed3
    - cpp: my_other_python_phlex_module

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (76.50%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
- Coverage   76.61%   76.50%   -0.11%     
==========================================
  Files         124      124              
  Lines        2733     2733              
  Branches      475      475              
==========================================
- Hits         2094     2091       -3     
- Misses        446      447       +1     
- Partials      193      195       +2     
Flag Coverage Δ
unittests 76.50% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/app/load_module.cpp 85.00% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfaa2e9...3ed89d9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel force-pushed the boost-json-string-view branch from d6b2b4b to 3ed89d9 Compare January 7, 2026 18:55
Copy link
Contributor

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (also verified it solves the issue in my configuration).

@knoepfel knoepfel merged commit 7f1168a into Framework-R-D:main Jan 8, 2026
35 of 36 checks passed
@knoepfel knoepfel deleted the boost-json-string-view branch January 8, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants