Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 7, 2026

Addressed review comment questioning whether .devcontainer/cmake_wrapper.sh and .devcontainer/ctest_wrapper.sh have proper executable permissions.

Investigation Results

  • Both wrapper scripts have been tracked by Git with mode 100755 (executable) since creation in commit 5c77ab9
  • Filesystem permissions confirm executable status (-rwxrwxr-x)
  • No changes required; original concern was incorrect

The wrapper scripts are properly configured and functioning as intended.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Address feedback on VSCode dev container setup Confirm executable permissions on devcontainer wrapper scripts Jan 7, 2026
Copilot AI requested a review from greenc-FNAL January 7, 2026 17:56
@greenc-FNAL greenc-FNAL marked this pull request as ready for review January 7, 2026 18:05
Copilot AI review requested due to automatic review settings January 7, 2026 18:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@greenc-FNAL greenc-FNAL merged commit e54f20e into feature/vscode-dev-container Jan 7, 2026
1 check passed
greenc-FNAL pushed a commit that referenced this pull request Jan 7, 2026
Addressed review comment questioning whether .devcontainer/cmake_wrapper.sh and .devcontainer/ctest_wrapper.sh have proper executable permissions.

Investigation Results
Both wrapper scripts have been tracked by Git with mode 100755 (executable) since creation in commit 5c77ab9
Filesystem permissions confirm executable status (-rwxrwxr-x)
No changes required; original concern was incorrect
The wrapper scripts are properly configured and functioning as intended.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
greenc-FNAL pushed a commit that referenced this pull request Jan 8, 2026
Addressed review comment questioning whether .devcontainer/cmake_wrapper.sh and .devcontainer/ctest_wrapper.sh have proper executable permissions.

Investigation Results
Both wrapper scripts have been tracked by Git with mode 100755 (executable) since creation in commit 5c77ab9
Filesystem permissions confirm executable status (-rwxrwxr-x)
No changes required; original concern was incorrect
The wrapper scripts are properly configured and functioning as intended.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants