refactor: generalize Zsqrtd instances for negative d#6
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the codebase by generalizing the
NoZeroDivisorsandIsDomaininstances forZsqrtd dwhendis a negative integer.Previously, these instances were explicitly defined for specific
Zsqrtdtypes, such asZsqrtd (-5). This change introduces a generalNoZeroDivisorsinstance forZsqrtd d(whered < 0) inANT/Basic.lean, from which theIsDomaininstance is then derived.Consequently, the specific instances for
Zsqrtd (-5)inANT/Ideals.leanare now simplified toinferInstance, relying on the newly generalized definitions. AFact ((-5 : ℤ) < 0)instance is added toANT/Ideals.leanto satisfy the condition for the generalized instances.This refactoring reduces code duplication and improves the reusability and clarity of algebraic property definitions for quadratic integer rings with negative discriminants.