Fix off-by-one in GEFullMat::backSubstituteIntoDU()#13
Open
fuzzybear3 wants to merge 1 commit intoFreeCAD:mainfrom
Open
Fix off-by-one in GEFullMat::backSubstituteIntoDU()#13fuzzybear3 wants to merge 1 commit intoFreeCAD:mainfrom
fuzzybear3 wants to merge 1 commit intoFreeCAD:mainfrom
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Body:
Summary
If you look at this PR #12 It had already recommended this change but seemed to have been overlooked.
Some info from Claude:
vectors of size n (valid range: 0 to n-1)
Details
GEFullMat::backSubstituteIntoDU() initializes the back-substitution correctly on line 23 using n - 1:
answerX->at(n - 1) = rightHandSideB->at(m - 1) / matrixA->at(m - 1)->at(n - 1);
But the first iteration of the loop used n instead of n - 1:
double sum = answerX->at(n) * rowi->at(n); // out of bounds
This is the same class of bug fixed in GESpMatFullPv::backSubstituteIntoDU() and causes a vector::_M_range_check exception at runtime.
GEFullMat is the base class for GEFullMatParPv and GEFullMatFullPv, neither of which override backSubstituteIntoDU(), so this affects
both full-pivot and partial-pivot dense matrix solves.