Conversation
fix: warning: unused variable ‘bool1’ [-Wunused-variable] warning: unused variable ‘bool2’ [-Wunused-variable] Clean code
|
@chennes is there someone who can/should review this PR & merge it? |
|
I generally leave the reviews of Ondsel Solver of @aiksiongkoh, but basically anyone can review this one. |
|
The comments are actual code commented out for future implementation. |
|
In other projects I'm involved in folks have branches with associated feature code there. It is still close the the main code but doesn't clutter things. Issues are another combination where the feature idea can be written up, then the assorted permalinks to the code prior to removal - or the branch can be made so it's easy to understand the feature/where things go. |
|
Sorry. It is not clear what I need to do. Is there an example for me to follow? Thanks. |
|
@mosfet80 would you be willing to reduce your PR so only the warnings are fixed & the commented code is left alone for now? |
fix:
warning: unused variable ‘bool1’ [-Wunused-variable]
warning: unused variable ‘bool2’ [-Wunused-variable]
Clean code