Add support for multi-key button pres bindings#127
Merged
jtsiomb merged 2 commits intoFreeSpacenav:masterfrom Nov 21, 2025
Merged
Add support for multi-key button pres bindings#127jtsiomb merged 2 commits intoFreeSpacenav:masterfrom
jtsiomb merged 2 commits intoFreeSpacenav:masterfrom
Conversation
Contributor
|
Thank you, this looks great! The only problem is that the protocol requests ( The only thing I'd do different would be to terminate the key sequence with a 0, instead of having a separate count array. But it's not important enough to change it, so I left that part unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
This is my first time contributing to an open-source project, so apologies if there is some etiquette I'm not familiar with.
I wanted to be able to bind buttons to key combinations (eg. Shift+1) to get support for the view controls in Onshape without modifying the keybinds.
This extends the button-press handing to allow for the use of up to 8 keys being bound to a single button, without breaking existing configs. I also added some logic to the config parsing, to give feedback to the user if their config is malformed.
Example /etc/spnavrc line:
kbmap30 = Shift_L+7The config I set up for Onshape is working properly, but I haven't done extensive testing for edge-cases.