tds_fix_column_size: Allow full size for output columns. #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an output column of type VARCHAR(n) or the like has no current size, send the type's maximum size; otherwise, the server will fill in only the first character/byte. Signed-off-by: Aaron M. Ucko <ucko@ncbi.nlm.nih.gov>
Contributor
|
This looks like a workaround for a problem in upper layer libraries. This function is supposed to make sure we don't screw with protocol level. I know ODBC is supposed to fill what it wants to be the size of the returned data, not leave as 0. I suppose that each library should detect this wrong request and report to the user. Need some more investigation. |
Contributor
Author
|
Ah, yeah, looks like the CTLIB API (my primary concern) works fine without this change these days, and already didn't need it in 1.0; I can't readily speak for the other two. Withdrawing accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an output column of type VARCHAR(n) or the like has no current size, send the type's maximum size; otherwise, the server will fill in only the first character/byte.
Split from #555.