-
Notifications
You must be signed in to change notification settings - Fork 175
Issue685 - support default values for BCP In on ASE #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
…d from data file Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
For bulk insert to possibly non-nullable datetime column with GETDATE() as default value. Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
|
Re. the old Ucko PRs - A large part of them was focused on having |
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
To prepare for adding the Defaults processing Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Validate size is correct Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
The validation code didn't support multiple hints,
and it truncated hints with arguments (e.g. ORDER).
The server will tell us anyway if a hint is invalid
so it doesn't seem necessary to validate at compile-time.
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
|
Force pushed to fix linux build errors & missing Signoff message . I noticed while fixing failure in t0016 that t0016 is actually a BCP test framework with 16 sub-cases of BCP tests. I should be able to replace my new test d_bcp_defaultdate with another case for t0016 , will do that now and force-push if you haven't started reviewing yet. Am also working on a test that will read the same sources as t0016 but execute by calling freebcp (or even MS/ASE native bcp for reference) instead of using DBlib api |
… conversion" This reverts commit 6db260b.
Signed-off-by: Matt McNabb <matthew.mcnabb@vmssoftware.com>
Summary of fixes on this PR:
freebcp -nwith SQL Server has had some fixes but there are still outstanding issues regarding nulls in which are covered on 686 and I'll work on at a later dated_bcptest relating to the handling of NULL and Default Values in bcpWITH()clause). I also removed the code that validates the hints, since the database will reject an invalid hint and I don't see what we gain by rejecting the hint on client side; it seems more forwards-compatible to let the database handle this.-kflag as supported by MSBCP (ASE bcp calls it--ignoreDefaults) which means that even if a column has a default value defined, BCP inserting a NULL will actually insert NULL and not the Default Value.Most of the content is covered by the new test cases, because
freebcpis a fairly thin wrapper around DBlib bcp API. However I also have made a local test script that does a few "front door" tests callingfreebcpdirectly to test the null/default handling, and did ad-hoc testing of-k.