Skip to content

Add type to composer.json #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add type to composer.json #773

wants to merge 1 commit into from

Conversation

sanzeeb3
Copy link

It would allow the composer/installers to install the package to a directory other than the default vendor directory.

@swashata
Copy link
Contributor

Hello @sanzeeb3 current WordPress.org guideline now requires our SDK to be installed inside a directory named vendor. Also from my understanding the default type is a library.

CleanShot 2025-04-30 at 11 01 06@2x

So could you please tell me what other benefit the explicit type has? Is it not redundant?

@sanzeeb3
Copy link
Author

@swashata - looks like that. It needs to be other than the library for the custom installer paths to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanzeeb3 @swashata