Fix SQLite migration: add default values for votes and hotness columns#143
Open
datlechin wants to merge 1 commit intoFriendsOfFlarum:2.xfrom
Open
Fix SQLite migration: add default values for votes and hotness columns#143datlechin wants to merge 1 commit intoFriendsOfFlarum:2.xfrom
datlechin wants to merge 1 commit intoFriendsOfFlarum:2.xfrom
Conversation
SQLite cannot add NOT NULL columns without default values to existing tables. Add default(0) to votes and hotness columns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SQLite cannot add NOT NULL columns without default values to existing tables. The migration
2019_07_09_000002_add_votes_and_hotness_to_discussionsfails with:This adds
->default(0)to bothvotesandhotnesscolumns, which is the logical default anyway (new discussions start with 0 votes and 0 hotness).